ardour/ardour
ardour/ardour
13
1
Fork 0
Code Pull Requests Releases Activity

MixerScene: only request actual value changes

Browse Source 
This is otherwise only caught later in the rt-thread after
scheduling a RealTimeOperation via AutomationControl::check_rt.

There is no need to schedule cross-thread events when the
value is not about to be changed.

This can greatly reduce the number of signals emitted by
restoring a slot, which improves performance and also prevents
the EventPool from filling up with useless events.
This commit is contained in:
Robin Gareus 2022-06-09 02:19:36 +02:00
parent 01b06906b0
commit c16b7b6dd5
Signed by: rgareus
GPG Key ID: A090BCE02CF57F04
1 changed files with 9 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
libs/ardour/mixer_scene.cc
View File

@ -105,14 +105,19 @@ MixerScene::recurse_to_master (boost::shared_ptr<PBD::Controllable> c, std::set
return false;
}
double old_value = ac ? ac->user_double () : c->get_value ();
if (sc && sc->slaved ()) {
double x = sc->reduce_by_masters (1.0);
if (x <= 0) {
c->set_value (0, Controllable::NoGroup);
if (x == 0) {
x = 0;
} else {
c->set_value (it->second / x, Controllable::NoGroup);
x = it->second / x;
}
} else {
if (x != old_value) {
c->set_value (x, Controllable::NoGroup);
}
} else if (it->second != old_value) {
c->set_value (it->second, Controllable::NoGroup);
}