ardour/ardour
ardour/ardour
13
1
Fork 0
Code Pull Requests Releases Activity

Plugin: bypass <> enabled mapping

Browse Source 
LV2 uses "enabled": -1: inactive, 0: bypassed, 1:enabled
VST3 has "bypass: 0:active, 1: bypassed
This commit is contained in:
Robin Gareus 2019-11-07 04:21:21 +01:00
parent 2d4e125802
commit bb62f7eaec
Signed by: rgareus
GPG Key ID: A090BCE02CF57F04
2 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
libs/ardour/ardour/plugin_insert.h
View File

@ -426,6 +426,7 @@ private:
void latency_changed ();
bool _latency_changed;
uint32_t _bypass_port;
bool _inverted_bypass_enable;
typedef std::map<uint32_t, boost::shared_ptr<ReadOnlyControl> >CtrlOutMap;
CtrlOutMap _control_outputs;

5
libs/ardour/plugin_insert.cc
View File

@ -88,6 +88,7 @@ PluginInsert::PluginInsert (Session& s, boost::shared_ptr<Plugin> plug)
, _maps_from_state (false)
, _latency_changed (false)
, _bypass_port (UINT32_MAX)
, _inverted_bypass_enable (false)
, _stat_reset (0)
{
/* the first is the master */
@ -716,7 +717,7 @@ PluginInsert::enable (bool yn)
activate ();
}
boost::shared_ptr<AutomationControl> ac = automation_control (Evoral::Parameter (PluginAutomation, 0, _bypass_port));
const double val = yn ? 1.0 : 0.0;
const double val = yn ^ _inverted_bypass_enable ? 1.0 : 0.0;
ac->set_value (val, Controllable::NoGroup);
#ifdef ALLOW_VST_BYPASS_TO_FAIL // yet unused, see also vst_plugin.cc
@ -748,7 +749,7 @@ PluginInsert::enabled () const
return Processor::enabled ();
} else {
boost::shared_ptr<const AutomationControl> ac = boost::const_pointer_cast<AutomationControl> (automation_control (Evoral::Parameter (PluginAutomation, 0, _bypass_port)));
return (ac->get_value () > 0 && _pending_active);
return ((ac->get_value () > 0) ^ _inverted_bypass_enable) && _pending_active;
}
}