ardour/ardour
ardour
/
ardour
13
1
Fork 0
Code Pull Requests Releases Activity

Fix string to float conversion when typing gain values in Gain Meter 

Remove the LocaleGuard so that the value of LC_NUMERIC is that of the users
locale and sscanf will parse the string correctly. For instance, with a locale
like nl_NL or fr_FR where the decimal point is different than the "C" locale,
only the number up to the decimal point will be parsed by sscanf and input
values will be rounded down.
This commit is contained in:
Tim Mayberry 2016-08-21 21:52:04 +10:00
parent aa349d3f8c
commit b424270208
1 changed files with 3 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
gtk2_ardour/gain_meter.cc
View File

@ -477,15 +477,9 @@ GainMeterBase::gain_activated ()
{
float f;
{
// Switch to user's preferred locale so that
// if they use different LC_NUMERIC conventions,
// we will honor them.
PBD::LocaleGuard lg;
if (sscanf (gain_display.get_text().c_str(), "%f", &f) != 1) {
return;
}
// Use the user's preferred locale/LC_NUMERIC setting
if (sscanf (gain_display.get_text().c_str(), "%f", &f) != 1) {
return;
}
/* clamp to displayable values */