ardour/ardour
ardour/ardour
13
1
Fork 0
Code Pull Requests Releases Activity

Fix a potential case where PresentationInfo type flag is not set (see comment for details)

Browse Source
This commit is contained in:
Ben Loftis 2020-02-04 13:07:23 -06:00
parent 00d1a0ed4d
commit a9b614fc18
1 changed files with 20 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
libs/ardour/route.cc
View File

@ -2617,6 +2617,26 @@ Route::set_state (const XMLNode& node, int version)
Stripable::set_state (node, version);
/* "This should never happen"
Stripable's job is to save/recall the PresentationInfo flags for bus/track audio/midi VCA etc.
But I found a case where no "type" flag is set, so the strip never shows up on any UI.
Since I don't know the source of the error, I have to assume that it could happen again.
So: if a stripable doesn't have any flags set, populate them from our audio/midi track/bus identity.
*/
PresentationInfo::Flag file_flags = _presentation_info.flags();
if ( !(file_flags & PresentationInfo::TypeMask) ) {
if (dynamic_cast<AudioTrack*>(this)) {
_presentation_info.set_flags ( PresentationInfo::Flag (file_flags | PresentationInfo::AudioTrack) );
}
else if (dynamic_cast<MidiTrack*>(this)) {
_presentation_info.set_flags ( PresentationInfo::Flag (file_flags | PresentationInfo::MidiTrack) );
}
else if (dynamic_cast<Route*>(this)) {
//no idea what this is, so let's call it an audio bus
_presentation_info.set_flags ( PresentationInfo::Flag (file_flags | PresentationInfo::AudioBus) );
}
}
node.get_property (X_("strict-io"), _strict_io);
if (is_monitor()) {