ardour/ardour
ardour
/
ardour
13
1
Fork 0
Code Pull Requests Releases Activity

Don't make MIDI regions in note mode completely invisible. 

This makes for extremely confusing behaviour, particularly when creating new
regions.  This is still probably too transparent, IMO, but at least isn't
totally mysterious.  "visible" is a bit of a misnomer in the code, now.
This commit is contained in:
David Robillard 2014-11-13 23:33:11 -05:00
parent 8907477271
commit a733a2a4c5
2 changed files with 12 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
gtk2_ardour/midi_region_view.cc
View File

@ -3221,7 +3221,7 @@ MidiRegionView::set_frame_color()
}
if (!rect_visible) {
f = UINT_RGBA_CHANGE_A (f, 0);
f = UINT_RGBA_CHANGE_A (f, 80);
}
frame->set_fill_color (f);

24
gtk2_ardour/time_axis_view_item.cc
View File

@ -719,12 +719,10 @@ uint32_t
TimeAxisViewItem::fill_opacity () const
{
if (!rect_visible) {
/* if the frame/rect is marked as invisible, then the
* fill should be transparent. simplest: set
* alpha/opacity to zero.
*/
return 0;
/* if the frame/rect is marked as "invisible", then the
fill should be translucent.parent.
*/
return 64;
}
if (_dragging) {
@ -781,19 +779,19 @@ TimeAxisViewItem::set_frame_color()
return;
}
frame->set_fill_color (get_fill_color());
frame->set_fill_color (get_fill_color());
set_frame_gradient ();
if (!_recregion) {
if (!_recregion) {
uint32_t f = ARDOUR_UI::config()->get_TimeAxisFrame();
if (!rect_visible) {
if (!rect_visible) {
/* make the frame outline be visible but rather transparent */
f = UINT_RGBA_CHANGE_A (f, 64);
}
f = UINT_RGBA_CHANGE_A (f, 64);
}
frame->set_outline_color (f);
}
frame->set_outline_color (f);
}
}
void