ardour/ardour
ardour/ardour
13
1
Fork 0
Code Pull Requests Releases Activity

Fix copying MIDI regions w/automation

Browse Source 
This fixes a bug introduced in d06a0d9c9d. The MIDI data
has to be written first, otherwise the CC-event do not exit
and MidiModel::source_interpolation_changed() crashes.
This commit is contained in:
Robin Gareus 2022-12-02 21:44:22 +01:00
parent b972301a3b
commit a3fdb544ee
Signed by: rgareus
GPG Key ID: A090BCE02CF57F04
1 changed files with 6 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
libs/ardour/midi_region.cc
View File

@ -161,19 +161,20 @@ MidiRegion::clone (boost::shared_ptr<MidiSource> newsrc, ThawList* tl) const
node.set_property (X_("flags"), newsrc->flags ());
node.set_property (X_("take-id"), newsrc->take_id());
/* compare to SMFSource::set_state */
newsrc->MidiSource::set_state (node, Stateful::current_state_version);
newsrc->Source::set_state (node, Stateful::current_state_version);
delete &node;
/* Lock our source since we'll be reading from it. write_to() will
take a lock on newsrc.
*/
Source::ReaderLock lm (ms->mutex());
if (ms->write_to (lm, newsrc, Temporal::Beats(), std::numeric_limits<Temporal::Beats>::max())) {
delete &node;
return boost::shared_ptr<MidiRegion> ();
}
/* compare to SMFSource::set_state */
newsrc->MidiSource::set_state (node, Stateful::current_state_version);
newsrc->Source::set_state (node, Stateful::current_state_version);
delete &node;
}
PropertyList plist (derive_properties ());