ardour/ardour
ardour
/
ardour
13
1
Fork 0
Code Pull Requests Releases Activity

VST3: Prevent recursive endless resizing 

Skip call to onSize() when the plugin's size already matches.

https://github.com/Ardour/ardour/pull/599
https://github.com/juce-framework/JUCE/pull/867
https://discourse.ardour.org/t/sonobus-vst3-gui-hogs-cpu-only-when-ran-inside-ardour-on-linux-but-not-windows/105573
This commit is contained in:
Robin Gareus 2021-03-11 18:19:21 +01:00
parent e07b3104bb
commit 9f3fba6988
Signed by: rgareus
GPG Key ID: A090BCE02CF57F04
3 changed files with 9 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
gtk2_ardour/vst3_hwnd_plugin_ui.cc
View File

@ -94,7 +94,9 @@ VST3HWNDPluginUI::view_size_allocate (Gtk::Allocation& allocation)
}
PBD::Unwinder<bool> uw (_resize_in_progress, true);
ViewRect rect;
if (view->getSize (&rect) == kResultOk) {
if (view->getSize (&rect) == kResultOk
&& ! (rect.right - rect.left == allocation.get_width () && rect.bottom - rect.top == allocation.get_height ()))
{
rect.right = rect.left + allocation.get_width ();
rect.bottom = rect.top + allocation.get_height ();
#if 0

4
gtk2_ardour/vst3_nsview_plugin_ui.mm
View File

@ -122,7 +122,9 @@ VST3NSViewPluginUI::view_size_allocate (Gtk::Allocation& allocation)
PBD::Unwinder<bool> uw (_resize_in_progress, true);
ViewRect rect;
if (view->getSize (&rect) == kResultOk) {
if (view->getSize (&rect) == kResultOk
&& !(rect.right - rect.left == allocation.get_width () && rect.bottom - rect.top == allocation.get_height () && rect.left == xx && rect.top == yy))
{
rect.left = xx;
rect.top = yy;
rect.right = rect.left + allocation.get_width ();

4
gtk2_ardour/vst3_x11_plugin_ui.cc
View File

@ -247,7 +247,9 @@ VST3X11PluginUI::view_size_allocate (Gtk::Allocation& allocation)
PBD::Unwinder<bool> uw (_resize_in_progress, true);
ViewRect rect;
if (view->getSize (&rect) == kResultOk) {
if (view->getSize (&rect) == kResultOk
&& ! (rect.right - rect.left == allocation.get_width () && rect.bottom - rect.top == allocation.get_height ()))
{
rect.right = rect.left + allocation.get_width ();
rect.bottom = rect.top + allocation.get_height ();
#if 0