ardour/ardour
ardour/ardour
13
1
Fork 0
Code Pull Requests Releases Activity

Speed up silence-stripping when there are many silent chunks

Browse Source 
Previously every region fragment was added one at a time,
with each emitting signals and updating the GUI. If there are a
few thousand regions Ardour can freeze for a significant amount
of time.

There is still the issue that the GUI freezes after the progress-bar
reached the end: consolidate overlapping ranges after analysis, then
add regions.

And Playlist::flush_notifications still emits
RegionFactory::CheckNewRegion() for every region individually
and RegionListBase::add_region becomes the bottleneck.

But at least adding 7k regions now returns in under 5 minutes
instead of taking over an hour.
This commit is contained in:
Robin Gareus 2022-03-08 16:15:15 +01:00
parent 4965c83ef3
commit 9cac17ea7d
Signed by: rgareus
GPG Key ID: A090BCE02CF57F04
1 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
gtk2_ardour/editor_ops.cc
View File

@ -6131,6 +6131,7 @@ Editor::apply_filter (Filter& filter, string command, ProgressReporter* progress
} else {
playlist->freeze ();
std::vector<boost::shared_ptr<Region> >::iterator res = filter.results.begin ();
/* first region replaces the old one */
@ -6142,6 +6143,7 @@ Editor::apply_filter (Filter& filter, string command, ProgressReporter* progress
playlist->add_region (*res, (*res)->position());
++res;
}
playlist->thaw ();
}