ardour/ardour
ardour/ardour
13
1
Fork 0
Code Pull Requests Releases Activity

Ignore pinout when copy/pasting plugins using Ctrl+c/v

Browse Source 
This can lead to invalid configuration and crashes in
case plugin-replication changes.

see also 9ab84a95f1
This commit is contained in:
Robin Gareus 2021-03-22 04:07:53 +01:00
parent a75c239c0c
commit 8fcbe789b4
Signed by: rgareus
GPG Key ID: A090BCE02CF57F04
1 changed files with 19 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
gtk2_ardour/processor_box.cc
View File

@ -2047,6 +2047,8 @@ ProcessorBox::object_drop (DnDVBox<ProcessorEntry>* source, ProcessorEntry* posi
/* strip side-chain state (processor inside processor must be a side-chain)
* otherwise we'll end up with duplicate ports-names.
* (this needs a better solution which retains connections)
*
* see also ProcessorBox::paste_processor_state
*/
state.remove_nodes_and_delete ("Processor");
state.remove_property ("count");
@ -3590,14 +3592,30 @@ ProcessorBox::paste_processor_state (const XMLNodeList& nlist, boost::shared_ptr
* only then update the ID)
*/
PBD::ID id = p->id();
XMLNode state (**niter);
/* strip side-chain state (processor inside processor must be a side-chain)
* otherwise we'll end up with duplicate ports-names.
* (this needs a better solution which retains connections)
*
* see also ProcessorBox::object_drop
*/
XMLNode state (**niter);
state.remove_nodes_and_delete ("Processor");
uint32_t count = 0;
state.get_property ("count", count);
state.remove_property ("count");
state.remove_property ("custom");
state.remove_nodes_and_delete ("ConfiguredInput");
state.remove_nodes_and_delete ("CustomSinks");
state.remove_nodes_and_delete ("ConfiguredOutput");
state.remove_nodes_and_delete ("PresetOutput");
state.remove_nodes_and_delete ("ThruMap");
for (uint32_t i = 0; i < count; ++i) {
state.remove_nodes_and_delete (string_compose ("InputMap-%1", i));
state.remove_nodes_and_delete (string_compose ("OutputMap-%1", i));
}
/* Controllable and automation IDs should not be copied */
PBD::Stateful::ForceIDRegeneration force_ids;
p->set_state (state, Stateful::current_state_version);