From 89eab2714f270ce726617d1b3505af87f144e33e Mon Sep 17 00:00:00 2001 From: Todd Naugle Date: Tue, 22 Jun 2021 22:16:19 -0500 Subject: [PATCH] Fix double call error in midi tracer handling Only basic midi ports use the _trace_parser and they enter here via cycle_start which will pass the _trace_parser to this function. No need to double up calls. --- libs/ardour/midi_port.cc | 14 -------------- 1 file changed, 14 deletions(-) diff --git a/libs/ardour/midi_port.cc b/libs/ardour/midi_port.cc index e29a2e1735..bd768a9def 100644 --- a/libs/ardour/midi_port.cc +++ b/libs/ardour/midi_port.cc @@ -201,10 +201,6 @@ MidiPort::read_and_parse_entire_midi_buffer_with_no_speed_adjustment (pframes_t parser.set_timestamp (now + timestamp); - if (_trace_parser) { - _trace_parser->set_timestamp (now + timestamp); - } - /* During this parsing stage, signals will be emitted from the * Parser, which will update anything connected to it. * @@ -218,20 +214,10 @@ MidiPort::read_and_parse_entire_midi_buffer_with_no_speed_adjustment (pframes_t parser.scanner (buf[1]); parser.scanner (0x40); /* default (off) velocity */ - if (_trace_parser) { - _trace_parser->scanner (0x80 | (buf[0] & 0x0F)); - _trace_parser->scanner (buf[1]); - _trace_parser->scanner (0x40); - } } else { for (size_t n = 0; n < size; ++n) { parser.scanner (buf[n]); } - if (_trace_parser) { - for (size_t n = 0; n < size; ++n) { - _trace_parser->scanner (buf[n]); - } - } } } }