ardour/ardour
ardour/ardour
13
1
Fork 0
Code Pull Requests Releases Activity

fix semantics of button press -> leave button -> button release, to match typical GUI toolkits

Browse Source
This commit is contained in:
Paul Davis 2014-02-28 17:17:23 -05:00
parent e60933650e
commit 895084a806
1 changed files with 9 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
gtk2_ardour/ardour_button.cc
View File

@ -709,7 +709,7 @@ ArdourButton::on_button_press_event (GdkEventButton *ev)
bool
ArdourButton::on_button_release_event (GdkEventButton *ev)
{
if ((_elements & Indicator) && _led_rect && _distinct_led_click) {
if (_hovering && (_elements & Indicator) && _led_rect && _distinct_led_click) {
if (ev->x >= _led_rect->x && ev->x < _led_rect->x + _led_rect->width &&
ev->y >= _led_rect->y && ev->y < _led_rect->y + _led_rect->height) {
signal_led_clicked(); /* EMIT SIGNAL */
@ -721,16 +721,17 @@ ArdourButton::on_button_release_event (GdkEventButton *ev)
unset_active_state ();
}
signal_clicked ();
if (_act_on_release) {
if (_action) {
_action->activate ();
return true;
if (_hovering) {
signal_clicked ();
if (_act_on_release) {
if (_action) {
_action->activate ();
return true;
}
}
}
return false;
}