ardour/ardour
ardour
/
ardour
13
1
Fork 0
Code Pull Requests Releases Activity

Revert "Keep Location List ordered by start-time" 

This reverts commit 67f6363dcd.

This VERY slow when there are many locations in the session
e.g. with #9568 it can take seconds.
This commit is contained in:
Robin Gareus 2023-12-08 22:12:48 +01:00
parent 67f6363dcd
commit 857d8096a9
Signed by: rgareus
GPG Key ID: A090BCE02CF57F04
2 changed files with 1 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
gtk2_ardour/location_ui.cc
View File

@ -352,6 +352,7 @@ LocationEditRow::set_location (Location *loc)
/* connect to per-location signals, since this row only cares about this location */
location->NameChanged.connect (connections, invalidator (*this), boost::bind (&LocationEditRow::name_changed, this), gui_context());
location->StartChanged.connect (connections, invalidator (*this), boost::bind (&LocationEditRow::start_changed, this), gui_context());
location->EndChanged.connect (connections, invalidator (*this), boost::bind (&LocationEditRow::end_changed, this), gui_context());
location->Changed.connect (connections, invalidator (*this), boost::bind (&LocationEditRow::location_changed, this), gui_context());
location->FlagsChanged.connect (connections, invalidator (*this), boost::bind (&LocationEditRow::flags_changed, this), gui_context());
@ -889,20 +890,6 @@ LocationUI::location_remove_requested (ARDOUR::Location *loc)
Glib::signal_idle().connect (sigc::bind (sigc::mem_fun(*this, &LocationUI::do_location_remove), loc));
}
void
LocationUI::queue_refresh_location_list ()
{
if (!_redisplay_connection.connected ()) {
_redisplay_connection = Glib::signal_idle().connect (sigc::mem_fun (*this, &LocationUI::idle_refresh_location_list), Glib::PRIORITY_HIGH_IDLE+10);
}
}
bool
LocationUI::idle_refresh_location_list ()
{
refresh_location_list ();
return false;
}
void
LocationUI::location_redraw_ranges ()
@ -1110,7 +1097,6 @@ LocationUI::set_session(ARDOUR::Session* s)
_session->locations()->added.connect (_session_connections, invalidator (*this), boost::bind (&LocationUI::location_added, this, _1), gui_context());
_session->locations()->removed.connect (_session_connections, invalidator (*this), boost::bind (&LocationUI::location_removed, this, _1), gui_context());
_session->locations()->changed.connect (_session_connections, invalidator (*this), boost::bind (&LocationUI::refresh_location_list, this), gui_context());
Location::start_changed.connect (_session_connections, invalidator (*this), boost::bind (&LocationUI::queue_refresh_location_list, this), gui_context());
_clock_group->set_clock_mode (clock_mode_from_session_instant_xml ());
} else {

3
gtk2_ardour/location_ui.h
View File

@ -202,9 +202,6 @@ private:
void location_remove_requested (ARDOUR::Location *);
void location_redraw_ranges ();
void queue_refresh_location_list ();
bool idle_refresh_location_list ();
sigc::connection _redisplay_connection;
gint do_location_remove (ARDOUR::Location *);