ardour/ardour
ardour/ardour
13
1
Fork 0
Code Pull Requests Releases Activity

A small experiment to try '#pragma GCC warning'

Browse Source 
MSVC is happy to ignore the above pragma although it aborts the build if it encounters #warning

#pragma GCC warning seems to work fine here for Clang - so start by changing just 1 x file to see if there's any detrimental effect for the other builds.
This commit is contained in:
John Emmas 2021-10-03 13:29:07 +01:00
parent b598750c2a
commit 808bfe0916
1 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
gtk2_ardour/editor_drag.cc
View File

@ -2332,7 +2332,7 @@ RegionRippleDrag::remove_unselected_from_views(timecnt_t const & amount, bool mo
rv->region()->set_position (rv->region()->position() + amount);
} else {
// restore the view to match the underlying region's original position
#warning NUTEMPO ALERT paul test this code in 5.x /* how can this work ... amount used to be in samples but ::move() expect pixels */
#pragma GCC warning("NUTEMPO ALERT paul test this code in 5.x") /* how can this work ... amount used to be in samples but ::move() expect pixels */
//rv->move(-amount, 0); // second parameter is y delta - seems 0 is OK
}
@ -3640,7 +3640,7 @@ TempoMarkerDrag::motion (GdkEvent* event, bool first_move)
_marker->reset_tempo (map->set_tempo (tempo, pos));
#warning paul, need a return status from set_tempo
#pragma GCC warning("paul, need a return status from set_tempo")
#if 0
if (!) {
aborted (true);
@ -3819,7 +3819,7 @@ BBTRulerDrag::motion (GdkEvent* event, bool first_move)
if (ArdourKeyboard::indicates_constraint (event->button.state)) {
/* adjust previous tempo to match pointer sample */
#warning NUTEMPO need to implement this
#pragma GCC warning("NUTEMPO need to implement this")
// _editor->session()->tempo_map().gui_stretch_tempo (_tempo, map.sample_at (_grab_qn), pf, _grab_qn, map.quarters_at_sample (pf));
}
@ -3902,7 +3902,7 @@ BBTRulerDrag::aborted (bool moved)
TempoMap::abort_update ();
}
#warning NUTEMPO fixme no tempo twist drag for now
#pragma GCC warning("NUTEMPO fixme no tempo twist drag for now")
#if 0
TempoTwistDrag::TempoTwistDrag (Editor* e, ArdourCanvas::Item* i)
@ -4102,7 +4102,7 @@ TempoEndDrag::motion (GdkEvent* event, bool first_move)
}
timepos_t const pos = adjusted_current_time (event, false);
#warning NUTEMPO implement this
#pragma GCC warning("NUTEMPO implement this")
// map->gui_stretch_tempo_end (&map->tempo_section_at_sample (_tempo->sample() - 1), map.sample_at_quarter_note (_grab_qn), pf);
ostringstream sstr;
@ -5598,7 +5598,7 @@ TimeFXDrag::finished (GdkEvent* event, bool movement_occurred)
#ifndef USE_RUBBERBAND
// Soundtouch uses fraction / 100 instead of normal (/ 1)
#warning NUTEMPO timefx request now uses a rational type so this needs revisiting
#pragma GCC warning("NUTEMPO timefx request now uses a rational type so this needs revisiting")
if (_primary->region()->data_type() == DataType::AUDIO) {
ratio = ((newlen - _primary->region()->length()) / newlen) * 100;
}