ardour/ardour
ardour
/
ardour
13
1
Fork 0
Code Pull Requests Releases Activity

there is no Properties::position any more (GUI) 

Position is a part of a length property (a duple specifying
"duration AT position", and there is no distinct property
for just the position itself
This commit is contained in:
Paul Davis 2021-09-25 16:48:55 -06:00
parent cc6c0f1263
commit 754230921d
7 changed files with 10 additions and 26 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
gtk2_ardour/editor_drag.cc
View File

@ -2962,7 +2962,7 @@ VideoTimeLineDrag::motion (GdkEvent* event, bool first_move)
rv->region()->suspend_property_changes();
}
rv->region()->set_position(timepos_t (i->initial_position + dt));
rv->region_changed(ARDOUR::Properties::position);
rv->region_changed (ARDOUR::Properties::length);
}
const samplepos_t offset = ARDOUR_UI::instance()->video_timeline->get_offset();

5
gtk2_ardour/editor_regions.cc
View File

@ -586,7 +586,6 @@ EditorRegions::clock_format_changed ()
PropertyChange change;
change.add (ARDOUR::Properties::start);
change.add (ARDOUR::Properties::length);
change.add (ARDOUR::Properties::position);
change.add (ARDOUR::Properties::sync_position);
change.add (ARDOUR::Properties::fade_in);
change.add (ARDOUR::Properties::fade_out);
@ -678,9 +677,9 @@ EditorRegions::populate_row (boost::shared_ptr<Region> region, TreeModel::Row co
/* the grid is most interested in the regions that are *visible* in the editor.
* this is a convenient place to flag changes to the grid cache, on a visible region */
PropertyChange grid_interests;
grid_interests.add (ARDOUR::Properties::position);
grid_interests.add (ARDOUR::Properties::length);
grid_interests.add (ARDOUR::Properties::sync_position);
if (what_changed.contains (grid_interests)) {
_editor->mark_region_boundary_cache_dirty ();
}
@ -701,7 +700,7 @@ EditorRegions::populate_row (boost::shared_ptr<Region> region, TreeModel::Row co
PropertyChange c;
const bool all = what_changed == c;
if (all || what_changed.contains (Properties::position)) {
if (all || what_changed.contains (Properties::length)) {
populate_row_position (region, row);
}
if (all || what_changed.contains (Properties::start) || what_changed.contains (Properties::sync_position)) {

8
gtk2_ardour/midi_region_view.cc
View File

@ -1375,14 +1375,6 @@ MidiRegionView::region_resized (const PropertyChange& what_changed)
{
RegionView::region_resized(what_changed); // calls RegionView::set_duration()
if (what_changed.contains (ARDOUR::Properties::position)) {
/* reset_width dependent_items() redisplays model */
}
if (what_changed.contains (ARDOUR::Properties::start) ||
what_changed.contains (ARDOUR::Properties::position)) {
}
/* catch end and start trim so we can update the view*/
if (!what_changed.contains (ARDOUR::Properties::start) &&
what_changed.contains (ARDOUR::Properties::length)) {

2
gtk2_ardour/recorder_ui.cc
View File

@ -839,7 +839,7 @@ void
RecorderUI::regions_changed (boost::shared_ptr<ARDOUR::RegionList>, PBD::PropertyChange const& what_changed)
{
PBD::PropertyChange interests;
interests.add (ARDOUR::Properties::position);
interests.add (ARDOUR::Properties::length);
if (what_changed.contains (interests)) {
gui_extents_changed ();

13
gtk2_ardour/region_editor.cc
View File

@ -191,7 +191,6 @@ RegionEditor::RegionEditor (Session* s, boost::shared_ptr<Region> r)
change.add (ARDOUR::Properties::start);
change.add (ARDOUR::Properties::length);
change.add (ARDOUR::Properties::position);
change.add (ARDOUR::Properties::sync_position);
bounds_changed (change);
@ -223,7 +222,6 @@ RegionEditor::region_changed (const PBD::PropertyChange& what_changed)
PropertyChange interesting_stuff;
interesting_stuff.add (ARDOUR::Properties::position);
interesting_stuff.add (ARDOUR::Properties::length);
interesting_stuff.add (ARDOUR::Properties::start);
interesting_stuff.add (ARDOUR::Properties::sync_position);
@ -368,19 +366,13 @@ RegionEditor::name_changed ()
void
RegionEditor::bounds_changed (const PropertyChange& what_changed)
{
if (what_changed.contains (ARDOUR::Properties::position) && what_changed.contains (ARDOUR::Properties::length)) {
if (what_changed.contains (ARDOUR::Properties::length)) {
position_clock.set (_region->position(), true);
end_clock.set (_region->nt_last(), true);
length_clock.set_duration (_region->length(), true);
} else if (what_changed.contains (ARDOUR::Properties::position)) {
position_clock.set (_region->position(), true);
end_clock.set (_region->nt_last(), true);
} else if (what_changed.contains (ARDOUR::Properties::length)) {
end_clock.set (_region->nt_last(), true);
length_clock.set_duration (_region->length(), true);
}
if (what_changed.contains (ARDOUR::Properties::sync_position) || what_changed.contains (ARDOUR::Properties::position)) {
if (what_changed.contains (ARDOUR::Properties::sync_position) || what_changed.contains (ARDOUR::Properties::length)) {
int dir;
timecnt_t off = _region->sync_offset (dir);
if (dir == -1) {
@ -454,7 +446,6 @@ RegionEditor::on_delete_event (GdkEventAny*)
change.add (ARDOUR::Properties::start);
change.add (ARDOUR::Properties::length);
change.add (ARDOUR::Properties::position);
change.add (ARDOUR::Properties::sync_position);
bounds_changed (change);

2
gtk2_ardour/region_gain_line.cc
View File

@ -115,7 +115,7 @@ AudioRegionGainLine::region_changed (const PropertyChange& what_changed)
PropertyChange interesting_stuff;
interesting_stuff.add (ARDOUR::Properties::start);
interesting_stuff.add (ARDOUR::Properties::position);
interesting_stuff.add (ARDOUR::Properties::length);
if (what_changed.contains (interesting_stuff)) {
reset ();

4
gtk2_ardour/region_view.cc
View File

@ -472,7 +472,9 @@ RegionView::region_resized (const PropertyChange& what_changed)
{
double unit_length;
if (what_changed.contains (ARDOUR::Properties::position)) {
/* position is stored in length */
if (what_changed.contains (ARDOUR::Properties::length)) {
set_position (_region->position(), 0);
}