ardour/ardour
ardour
/
ardour
13
1
Fork 0
Code Pull Requests Releases Activity

Guard set_transient_for for NULL windows 

While there should always be a top-level, backtraces
provided by some [windows] users show that it can be NULL
in some scenarios.
This commit is contained in:
Robin Gareus 2023-04-04 01:38:33 +02:00
parent 29c6817599
commit 7302aefbee
Signed by: rgareus
GPG Key ID: A090BCE02CF57F04
4 changed files with 18 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
gtk2_ardour/io_plugin_window.cc
View File

@ -335,7 +335,9 @@ IOPluginWindow::IOPlugUI::edit_plugin (bool custom_ui)
_window_proxy->set_custom_ui_mode (custom_ui);
_window_proxy->show_the_right_window ();
Gtk::Window* tlw = dynamic_cast<Gtk::Window*> (get_toplevel ());
_window_proxy->set_transient_for (*tlw);
if (tlw) {
_window_proxy->set_transient_for (*tlw);
}
}
bool

4
gtk2_ardour/port_insert_ui.cc
View File

@ -288,8 +288,10 @@ PortInsertUI::edit_latency_button_clicked ()
different WM's as possible.
*/
_latency_dialog->set_keep_above (true);
_latency_dialog->set_transient_for (*_parent);
_latency_dialog->add (*_latency_gui);
if (_parent) {
_latency_dialog->set_transient_for (*_parent);
}
}
_latency_gui->refresh ();

13
gtk2_ardour/processor_box.cc
View File

@ -4461,7 +4461,9 @@ ProcessorBox::edit_processor (std::shared_ptr<Processor> processor)
proxy->show_the_right_window ();
Gtk::Window* tlw = dynamic_cast<Gtk::Window*> (get_toplevel ());
proxy->set_transient_for (*tlw);
if (tlw) {
proxy->set_transient_for (*tlw);
}
}
}
@ -4485,7 +4487,9 @@ ProcessorBox::generic_edit_processor (std::shared_ptr<Processor> processor)
proxy->show_the_right_window ();
Gtk::Window* tlw = dynamic_cast<Gtk::Window*> (get_toplevel ());
proxy->set_transient_for (*tlw);
if (tlw) {
proxy->set_transient_for (*tlw);
}
}
}
@ -4500,8 +4504,9 @@ ProcessorBox::manage_pins (std::shared_ptr<Processor> processor)
proxy->get (true);
Gtk::Window* tlw = dynamic_cast<Gtk::Window*> (get_toplevel ());
assert (tlw);
proxy->set_transient_for (*tlw);
if (tlw) {
proxy->set_transient_for (*tlw);
}
proxy->present();
}

4
gtk2_ardour/trigger_clip_picker.cc
View File

@ -693,7 +693,9 @@ TriggerClipPicker::open_dir ()
Gtk::Window* tlw = dynamic_cast<Gtk::Window*> (get_toplevel ());
assert (tlw);
#ifndef __APPLE__
_fcd.set_transient_for (*tlw);
if (tlw) {
_fcd.set_transient_for (*tlw);
}
#endif
int result = _fcd.run ();