ardour/ardour
ardour/ardour
13
1
Fork 0
Code Pull Requests Releases Activity

Fix edit-note dialog length calculation

Browse Source 
The AudioClock uses samples. Duration calculation is
done using the current clock pos. The returned distance is
using Beats, can be directly used for all notes regardless of their
position.

Now that this works correctly the dialog can also be made available
for multiple-selection.
This commit is contained in:
Robin Gareus 2022-06-04 04:58:31 +02:00
parent 637971a7df
commit 720303a217
Signed by: rgareus
GPG Key ID: A090BCE02CF57F04
2 changed files with 3 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
gtk2_ardour/edit_note_dialog.cc
View File

@ -118,7 +118,7 @@ EditNoteDialog::EditNoteDialog (MidiRegionView* rv, set<NoteBase*> n)
offset = timecnt_t (_region_view->region()->position(), timepos_t()) + dur;
_length_clock.set_is_duration (true, pos);
_length_clock.set_duration (offset, true);
_length_clock.set (pos, true, offset);
/* Set up `set all notes...' buttons' sensitivity */
@ -226,17 +226,10 @@ EditNoteDialog::done (int r)
}
}
}
if (!_length_all.get_sensitive() || _length_all.get_active ()) {
/* get current note duration, interpreted as beats at the time indicated by the _time_clock (the new note position) */
Beats const duration = _length_clock.current_duration (_time_clock.current_time()).beats ();
/* compute end of note */
Beats const new_note_end_source_relative_beats = new_note_time_source_relative_beats + duration;
Beats const new_note_length_beats = _length_clock.current_duration ().beats ();
for (set<NoteBase*>::iterator i = _events.begin(); i != _events.end(); ++i) {
Beats const new_note_length_beats = new_note_end_source_relative_beats - (*i)->note()->time();
if (new_note_length_beats != (*i)->note()->length()) {
_region_view->change_note_length (*i, new_note_length_beats);
had_change = true;

3
gtk2_ardour/editor.cc
View File

@ -6614,9 +6614,6 @@ Editor::popup_note_context_menu (ArdourCanvas::Item* item, GdkEvent* event)
items.push_back(MenuElem(_("Edit..."),
sigc::bind(sigc::mem_fun(*this, &Editor::edit_notes), &mrv)));
if (sel_size != 1) {
items.back().set_sensitive (false);
}
items.push_back(MenuElem(_("Transpose..."),
sigc::bind(sigc::mem_fun(*this, &Editor::transpose_regions), rs)));