ardour/ardour
ardour/ardour
13
1
Fork 0
Code Pull Requests Releases Activity

add explanatory comment re: region duplication positioning

Browse Source 
This is currently an unsolved problem-that-may-not-be-a-problem.
This commit is contained in:
Paul Davis 2022-10-23 22:31:31 -06:00
parent 75a990da8c
commit 570aead3b1
1 changed files with 14 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
gtk2_ardour/editor_ops.cc
View File

@ -5266,12 +5266,22 @@ Editor::duplicate_some_regions (RegionSelection& regions, float times)
latest_regionviews.clear ();
sigc::connection c = rtv->view()->RegionViewAdded.connect (sigc::mem_fun(*this, &Editor::collect_new_region_view));
/* end time is an inclusive end; we need to place the
* duplicated region after that.
/* XXX problem arew here. When duplicating audio regions, the
* next one must be positioned 1 sample after the end of the
* prior region.
*
* For MIDI, this is not requiredd, because we allow MIDI
* events to be simultaneous without affecting semantics.
*
* HOWEVER, opaque MIDI regions will cause an underlying note
* off at the end of earlier region to not be delivered. In
* reality, the note tracker will fix this by resolving all
* on-notes at the region's end, but that does not seem like a
* good solution.
*/
timepos_t position = end_time.increment();
position += start_time.distance (r->position());
timepos_t position = end_time + (start_time.distance (r->position()));
position.increment ();
playlist = (*i)->region()->playlist();