From 520b209c83505bce693109dd4ea34bbc3da02e7b Mon Sep 17 00:00:00 2001 From: Robin Gareus Date: Wed, 31 May 2023 15:53:12 +0200 Subject: [PATCH] NO-OP: update comments --- gtk2_ardour/editor_sources.cc | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/gtk2_ardour/editor_sources.cc b/gtk2_ardour/editor_sources.cc index 933ee4ceab..47fd6ec2ae 100644 --- a/gtk2_ardour/editor_sources.cc +++ b/gtk2_ardour/editor_sources.cc @@ -222,6 +222,12 @@ EditorSources::remove_selected_sources () for (auto const& region : regions) { _change_connection.block (true); + /* Note: this ignores regions without RegionView. + * When removing sources (opt == 2), + * Playlist::region_going_away takes care of that + * (Source::drop_references -> Region::source_deleted, + * -> Region::drop_references). see f58f5bef55a5aa1 + */ _editor->set_selected_regionview_from_region_list (region, Selection::Add); _change_connection.block (false); } @@ -237,8 +243,6 @@ EditorSources::remove_selected_sources () for (auto const& s : to_be_removed) { _session->remove_source (s); // this operation is (currently) not undo-able } - // TODO Session::_history.clear(); or otherwise remove all - // undo operations that reference regions using the removed sources } } }