From 39d4bbf5e16662929719bb1884b741ffc8805adf Mon Sep 17 00:00:00 2001 From: nick_m Date: Sat, 23 May 2015 23:19:00 +1000 Subject: [PATCH] Clarify the convention on modifiers and drags. --- gtk2_ardour/editor_drag.cc | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/gtk2_ardour/editor_drag.cc b/gtk2_ardour/editor_drag.cc index f9222ac35a..00811f6eea 100644 --- a/gtk2_ardour/editor_drag.cc +++ b/gtk2_ardour/editor_drag.cc @@ -404,6 +404,11 @@ Drag::motion_handler (GdkEvent* event, bool from_autoscroll) } else { _initially_vertical = false; } + /** check constraints for this drag. + * Note that the current convention is to use "contains" for + * key modifiers during motion and "equals" when initiating a drag. + * In this case we haven't moved yet, so "equals" applies here. + */ if (Config->get_edit_mode() != Lock) { if (event->motion.state & Gdk::BUTTON2_MASK) { // if dragging with button2, the motion is x constrained, with constraint modifier it is y constrained