ardour/ardour
ardour/ardour
13
1
Fork 0
Code Pull Requests Releases Activity

Fix concurrency issue when deactivating plugins

Browse Source 
Processor::deactivate must not be called concurrently with
processing. e.g. Threading rules https://lv2plug.in/ns/lv2core

This fixes a potential crash when freezing tracks
This commit is contained in:
Robin Gareus 2022-11-13 00:19:40 +01:00
parent 3fcd8b659d
commit 376b50a6ae
Signed by: rgareus
GPG Key ID: A090BCE02CF57F04
1 changed files with 9 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
libs/ardour/plugin_insert.cc
View File

@ -736,9 +736,7 @@ PluginInsert::deactivate ()
_timing_stats.reset ();
Processor::deactivate ();
for (Plugins::iterator i = _plugins.begin(); i != _plugins.end(); ++i) {
(*i)->deactivate ();
}
/* Plugin::deactivate is called from run() */
const samplecnt_t l = effective_latency ();
if (_plugin_signal_latency != l) {
@ -1307,7 +1305,14 @@ PluginInsert::run (BufferSet& bufs, samplepos_t start_sample, samplepos_t end_sa
_timing_stats.reset ();
}
if (g_atomic_int_compare_and_exchange (&_flush, 1, 0)) {
if (_active != _pending_active && !_pending_active) {
/* deactivate */
for (Plugins::iterator i = _plugins.begin(); i != _plugins.end(); ++i) {
(*i)->deactivate ();
}
}
if (check_active () && g_atomic_int_compare_and_exchange (&_flush, 1, 0)) {
for (Plugins::iterator i = _plugins.begin(); i != _plugins.end(); ++i) {
(*i)->flush ();
}