ardour/ardour
ardour
/
ardour
13
1
Fork 0
Code Pull Requests Releases Activity

PatchChange: use correct hwx constants to detect/set "unset" byte values

This commit is contained in:
Paul Davis 2022-02-02 15:03:49 -07:00
parent 31f4d8a2ca
commit 374faa0d5c
1 changed files with 9 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
libs/evoral/evoral/PatchChange.h
View File

@ -84,16 +84,16 @@ public:
return *this;
}
void unset() {
_bank_change_msb.buffer()[1] = 0xf; /* unset */
_bank_change_lsb.buffer()[1] = 0xf; /* unset */
_program_change.buffer()[1] = 0xf; /* unset */
_bank_change_msb.buffer()[1] = 0x80; /* unset */
_bank_change_lsb.buffer()[1] = 0x80; /* unset */
_program_change.buffer()[1] = 0x80; /* unset */
assert (!is_set());
}
bool is_set() const {
return ((_bank_change_msb.buffer()[1] & 0xf) == 0) &&
((_bank_change_lsb.buffer()[1] & 0xf) == 0) &&
((_program_change.buffer()[1] & 0xf) == 0);
return ((_bank_change_msb.buffer()[1] & 0x80) == 0) &&
((_bank_change_lsb.buffer()[1] & 0x80) == 0) &&
((_program_change.buffer()[1] & 0x80) == 0);
}
event_id_t id () const {
@ -117,12 +117,9 @@ public:
}
void set_channel (uint8_t c) {
_bank_change_msb.buffer()[0] &= 0xf0;
_bank_change_msb.buffer()[0] |= c;
_bank_change_lsb.buffer()[0] &= 0xf0;
_bank_change_lsb.buffer()[0] |= c;
_program_change.buffer()[0] &= 0xf0;
_program_change.buffer()[0] |= c;
_bank_change_msb.buffer()[0] = c & 0xf;
_bank_change_lsb.buffer()[0] = c & 0xf;
_program_change.buffer()[0] = c & 0xf;
}
uint8_t program () const {