ardour/ardour
ardour/ardour
13
1
Fork 0
Code Pull Requests Releases Activity

Fix automation alignment for latent plugins

Browse Source 
This also solves bi-stable automation for plugins where latency
can change due to automation. e.g.

cycle 1: run (t): automation (t) = on: -> increase latency
cycle 2: run (t-latency): automation (t-latency) = off -> decrease latency
repeat.
This commit is contained in:
Robin Gareus 2019-12-09 18:23:17 +01:00
parent 319b029579
commit 21f682164e
Signed by: rgareus
GPG Key ID: A090BCE02CF57F04
1 changed files with 18 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

28
libs/ardour/route.cc
View File

@ -513,6 +513,24 @@ Route::process_output_buffers (BufferSet& bufs,
pspeed = 0;
}
/* Note: plugin latency may change. The plugin does inform the session via
* processor_latency_changed(). But the session may not yet have gotten around to
* update the actual worste-case and update this track's _signal_latency.
* So there can be cases where adding up all latencies may not equal _signal_latency.
*
* Also running a plugin may change the plugin's latency, so we need to
* add the latency first. Otherwise this can lead to bistable case
* in case of automation playback. e.g.
*
* cycle 1: run (t): automation (t) = on: -> increase latency
* cycle 2: run (t-latency): automation (t-latency) = off -> decrease latency
* reapeat.
*/
if ((*i)->active ()) {
latency += (*i)->effective_latency ();
}
if (speed < 0) {
(*i)->run (bufs, start_sample + latency, end_sample + latency, pspeed, nframes, *i != _processors.back());
} else {
@ -521,16 +539,6 @@ Route::process_output_buffers (BufferSet& bufs,
bufs.set_count ((*i)->output_streams());
/* Note: plugin latency may change. While the plugin does inform the session via
* processor_latency_changed(). But the session may not yet have gotten around to
* update the actual worste-case and update this track's _signal_latency.
*
* So there can be cases where adding up all latencies may not equal _signal_latency.
*/
if ((*i)->active ()) {
latency += (*i)->effective_latency ();
}
if (re_inject_oob_data) {
write_out_of_band_data (bufs, nframes);
}