From 2079a150ddf9bfeda3c7dc5f56b8b33846c7ca06 Mon Sep 17 00:00:00 2001 From: Paul Davis Date: Mon, 16 May 2022 14:38:45 -0600 Subject: [PATCH] probable fix for Mackie vpot press/release misbehavior in sends (and plugin) subview The accessed control needs to reflect the current subview banking --- libs/surfaces/mackie/subview.cc | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/libs/surfaces/mackie/subview.cc b/libs/surfaces/mackie/subview.cc index 2345acd9c1..b6765975fe 100644 --- a/libs/surfaces/mackie/subview.cc +++ b/libs/surfaces/mackie/subview.cc @@ -673,6 +673,11 @@ SendsSubview::notify_send_level_change (uint32_t global_strip_position, bool for void SendsSubview::handle_vselect_event(uint32_t global_strip_position) { + /* adjust global_strip_position to make sure we're accessing the + * correct controllable since we might be banked within the subview. + */ + global_strip_position += _current_bank; + /* Send mode: press enables/disables the relevant * send, but the vpot is bound to the send-level so we * need to lookup the enable/disable control @@ -1086,6 +1091,11 @@ void PluginSelect::setup_vpot( void PluginSelect::handle_vselect_event(uint32_t global_strip_position, boost::shared_ptr subview_stripable) { + /* adjust global_strip_position to make sure we're accessing the + * correct controllable since we might be banked within the subview. + */ + global_strip_position += _current_bank; + /* PluginSelect mode: press selects the plugin shown on the strip's LCD */ if (!subview_stripable) { return;