remove another NUTEMPO #warning (see comment)

This commit is contained in:
Paul Davis 2021-01-19 16:51:16 -07:00
parent f321dd4dac
commit 068cc4135f
2 changed files with 11 additions and 2 deletions

View File

@ -693,7 +693,6 @@ RegionView::set_samples_per_pixel (double fpp)
for (vector<GhostRegion*>::iterator i = ghosts.begin(); i != ghosts.end(); ++i) {
(*i)->set_samples_per_pixel (fpp);
#warning NUTEMPO should GhostRegion really be using samples for length/duration?
(*i)->set_duration (_region->length_samples() / fpp);
}

View File

@ -456,7 +456,17 @@ Curve::multipoint_eval (Temporal::timepos_t const & x) const
case ControlList::Curved:
if (after->coeff) {
ControlEvent* ev = after;
#warning NUTEMPO fixme possible overflow ... multiplyng two position types .. also, units?
/* As of Jan 2020, we only use Curved
* for fade in/out curves (of audio
* regions).
*
* This means that x is a relatively
* small value (sample count into the
* fade) amd we do not need to worry
* about the square overflowing.
*/
double x2 = x.val() * x.val();
return ev->coeff[0] + (ev->coeff[1] * x.val()) + (ev->coeff[2] * x2) + (ev->coeff[3] * x2 * x.val());
}