ardour/ardour
ardour
/
ardour
13
1
Fork 0
Code Pull Requests Releases Activity

do not delete display (context) menu when adding a new automation child lane 

The manu is rebuilt every time it is required, no need to delete it. In addition, deleting it
in the middle of an event handler causes memory corruption because the entire menu (with all
items and submenus) is deleted before event handling for the menu is completed
This commit is contained in:
Paul Davis 2021-05-13 10:23:43 -06:00
parent a01377f168
commit 03db585f24
1 changed files with 0 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
gtk2_ardour/stripable_time_axis.cc
View File

@ -95,16 +95,6 @@ StripableTimeAxisView::add_automation_child (Evoral::Parameter param, boost::sha
if (show && !no_redraw) {
request_redraw ();
}
if (!ARDOUR::parameter_is_midi((AutomationType)param.type())) {
/* MIDI-related parameters are always in the menu, there's no
reason to rebuild the menu just because we added a automation
lane for one of them. But if we add a non-MIDI automation
lane, then we need to invalidate the display menu.
*/
delete display_menu;
display_menu = 0;
}
}
void